Search Linux Wireless

Re: [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 22, 2012 at 10:58 PM, Tobias Diedrich
<ranma+openwrt@xxxxxxxxxxxx> wrote:
> Helmut Schaa wrote:
>> On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich
>> <ranma+openwrt@xxxxxxxxxxxx> wrote:
>> > rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER
>> > respectively, similar to how it is already done in rt2[45]00pci.c
>> >
>> > rt2800lib.c doesn't initialize max_power and thus after
>> > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next.git;a=commitdiff;h=eccc068e8e84c8fe997115629925e0422a98e4de
>> > was applied txpower is limited to 0 for these devices.
>> >
>> > This should be the proper fix compared to the net/wireless/reg.c
>> > hack in http://patchwork.openwrt.org/patch/2165/
>>
>> Btw. Tobias, did this affect the real tx power of the device at all or
>> is this just
>> a cosmetic issue?
>
> Hmm, apparently setting txpower has no effect?
> Is it not implemented in the driver?

It is, but only for devices with correct tx power limit in the eeprom.

> i.e. regardless of "iw (dev wlan0|phy phy0) set txpower fixed (100|2000)"
> I don't see any significant chane in Wifi Analyzer on my Android
> phone.
>
> (The real reason I couldn't connect to the AP at all was a different recent
> change)

So, we can actually drop this patch then?

Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux