Search Linux Wireless

Re: [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Helmut Schaa wrote:
> On Tue, May 22, 2012 at 10:58 PM, Tobias Diedrich
> <ranma+openwrt@xxxxxxxxxxxx> wrote:
> > Helmut Schaa wrote:
> >> On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich
> >> <ranma+openwrt@xxxxxxxxxxxx> wrote:
> >> > rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER
> >> > respectively, similar to how it is already done in rt2[45]00pci.c
> >> >
> >> > rt2800lib.c doesn't initialize max_power and thus after
> >> > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next.git;a=commitdiff;h=eccc068e8e84c8fe997115629925e0422a98e4de
> >> > was applied txpower is limited to 0 for these devices.
> >> >
> >> > This should be the proper fix compared to the net/wireless/reg.c
> >> > hack in http://patchwork.openwrt.org/patch/2165/
> >>
> >> Btw. Tobias, did this affect the real tx power of the device at all or
> >> is this just
> >> a cosmetic issue?
> >
> > Hmm, apparently setting txpower has no effect?
> > Is it not implemented in the driver?
> 
> It is, but only for devices with correct tx power limit in the eeprom.

Why?
Lowering the tx power should never be an issue, right?
Or are you saying I'm stuck with 0dBm txpower?
That would be an issue by itself.
Why not use min(hw defaults, regulatory limits) as maximum if there is
no limit in the eeprom?
Do I have to add an eeprom fixup that will insert valid txpower
limit bytes as an additional step after the eeprom extraction from flash
to make this work?

-- 
Tobias						PGP: http://8ef7ddba.uguu.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux