On Wed, 2012-04-04 at 15:31 -0700, Thomas Pedersen wrote: > +void cfg80211_ch_switch_notify(struct net_device *dev, int freq, > + enum nl80211_channel_type type, gfp_t gfp) > + wdev_lock(wdev); So ... typically we pass the gfp_t since we want to allow these being called in atomic contexts, but now you use the lock so that's impossible anyway. I think this is a bit dangerous. If you call this function from within a context where cfg80211 calls you, for example, you will deadlock. At least add more documentation about that :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
