Search Linux Wireless

RE: [PATCH 10/15] mwifiex: fix checkpatch --strict warnings/errors Part 4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe,

Thanks for your comments.

> On Mon, 2012-03-12 at 19:38 -0700, Bing Zhao wrote:
> []
> > diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
> []
> > @@ -495,7 +495,7 @@ mwifiex_set_mac_address(struct net_device *dev, void *addr)
> >  		memcpy(priv->netdev->dev_addr, priv->curr_addr, ETH_ALEN);
> >  	else
> >  		dev_err(priv->adapter->dev, "set mac address failed: ret=%d"
> > -					    "\n", ret);
> > +			"\n", ret);
> 
> Feel free to exceed 80 columns for formats.
> This would be much more readable by coalescing the
> formats like either of:
> 
> 		dev_err(priv->adapter->dev, "set mac address failed: ret=%d\n",
> 			ret);
> or
> 		dev_err(priv->adapter->dev,
> 			"set mac address failed: ret=%d\n", ret);

We will incorporate this change in v2.

Thanks,
Bing

��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux