On Mon, 2012-03-12 at 19:38 -0700, Bing Zhao wrote: [] > diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c [] > @@ -495,7 +495,7 @@ mwifiex_set_mac_address(struct net_device *dev, void *addr) > memcpy(priv->netdev->dev_addr, priv->curr_addr, ETH_ALEN); > else > dev_err(priv->adapter->dev, "set mac address failed: ret=%d" > - "\n", ret); > + "\n", ret); Feel free to exceed 80 columns for formats. This would be much more readable by coalescing the formats like either of: dev_err(priv->adapter->dev, "set mac address failed: ret=%d\n", ret); or dev_err(priv->adapter->dev, "set mac address failed: ret=%d\n", ret); [] > diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c [] > @@ -391,15 +391,16 @@ static int mwifiex_pcie_create_txbd_ring(struct mwifiex_adapter *adapter) > card->txbd_ring_pbase = virt_to_phys(card->txbd_ring_vbase); > > dev_dbg(adapter->dev, "info: txbd_ring - base: %p, pbase: %#x:%x," > - "len: %x\n", card->txbd_ring_vbase, > - (u32)card->txbd_ring_pbase, > - (u32)((u64)card->txbd_ring_pbase >> 32), > - card->txbd_ring_size); > + "len: %x\n", card->txbd_ring_vbase, > + (u32)card->txbd_ring_pbase, > + (u32)((u64)card->txbd_ring_pbase >> 32), > + card->txbd_ring_size); etc... -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
