Search Linux Wireless

Re: [PATCH 1/2] ieee80211: Introduce ieee80211_has_frags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-12-08 at 10:38 +0100, Helmut Schaa wrote:
> On Thu, Dec 8, 2011 at 10:25 AM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> >> +{
> >> +     return (seq_ctrl & cpu_to_le16(IEEE80211_SCTL_FRAG)) != 0;
> >> +}
> >> +
> >
> > Maybe you should move that close to ieee80211_has_morefrags() so it's
> > easy to tell the difference? :-) (that doesn't use bool either, heh)
> 
> Since all ieee80211_is/has_* functions use int already I took the same
> approach.
> 
> And ieee80211_has_morefrags operates on the frame control while
> this operates on seq_ctrl. Hence, I placed it at the end but if you prefer
> to have it closer to ieee80211_has_morefrags I can do that too :)

Oh, well, whatever, I don't really care :)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux