Search Linux Wireless

Re: [PATCH 1/2] ieee80211: Introduce ieee80211_has_frags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-12-08 at 10:21 +0100, Helmut Schaa wrote:
> Signed-off-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx>
> ---
>  include/linux/ieee80211.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
> index 17f2a76..18326eb 100644
> --- a/include/linux/ieee80211.h
> +++ b/include/linux/ieee80211.h
> @@ -544,6 +544,15 @@ static inline int ieee80211_is_qos_nullfunc(__le16 fc)
>  	       cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_QOS_NULLFUNC);
>  }
>  
> +/**
> + * ieee80211_has_frag - check if IEEE80211_SCTL_FRAG is set
> + * @seq_ctrl: frame sequence control bytes in little-endian byteorder
> + */
> +static inline int ieee80211_has_frag(__le16 seq_ctrl)

bool? not like I care much though

Would _is_frag() read nicer? The piece you're checking is a fragment I
think?

> +{
> +	return (seq_ctrl & cpu_to_le16(IEEE80211_SCTL_FRAG)) != 0;
> +}
> +

Maybe you should move that close to ieee80211_has_morefrags() so it's
easy to tell the difference? :-) (that doesn't use bool either, heh)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux