On Thu, Sep 29, 2011 at 12:21 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> >> @@ -1257,7 +1265,7 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata, >> >> tx->flags |= IEEE80211_TX_UNICAST; >> >> if (unlikely(local->wifi_wme_noack_test)) >> >> info->flags |= IEEE80211_TX_CTL_NO_ACK; >> >> - else >> >> + else if (!(info->flags & IEEE80211_TX_CTL_NO_ACK)) >> >> info->flags &= ~IEEE80211_TX_CTL_NO_ACK; >> > >> > ?? >> >> Don't remove the IEEE80211_TX_CTL_NO_ACK flag when it was set via radiotap. > > Well, ok, but the logic is: > > if (flag not set) > unset flag > > which is kinda useless, right? Haha, right! Since the tx info is always initialized to 0 the code was useless before as well :) but now it is even more useless ... I guess it was good for documentary purposes. Hence, I'll replace it with a comment instead ... Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
