On Thu, Sep 29, 2011 at 11:59 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2011-09-29 at 11:27 +0200, Helmut Schaa wrote: >> Allow injected unicast frames to be sent without having to wait >> for an ACK. >> >> Signed-off-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx> >> --- >> >> Just in case you're interested in what's the intended purpose of this: >> >> Some clients are staying on scanned channels for a very short period of >> time. hostapd sends out probe responses for each configured BSSID. Under >> some circumstances I can see that the client already left the channel >> while some probe responses are still sent out and thus retried. This >> consumes quite some airtime. Commercial wireless APs (Aruba for example) >> seem to disable retries for probe responses to mitigate such issues. > > Makes sense, but I wonder if we really should continue using > radiotap :-) Maybe mgmt-tx in nl80211 would be appropriate. Hmm, not sure how much work that would be ... >> @@ -1257,7 +1265,7 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata, >> tx->flags |= IEEE80211_TX_UNICAST; >> if (unlikely(local->wifi_wme_noack_test)) >> info->flags |= IEEE80211_TX_CTL_NO_ACK; >> - else >> + else if (!(info->flags & IEEE80211_TX_CTL_NO_ACK)) >> info->flags &= ~IEEE80211_TX_CTL_NO_ACK; > > ?? Don't remove the IEEE80211_TX_CTL_NO_ACK flag when it was set via radiotap. Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
