On Wed, Aug 24, 2011 at 05:33:30PM +0300, Kalle Valo wrote: > On 08/24/2011 05:30 PM, Vasanthakumar Thiagarajan wrote: > > On Wed, Aug 24, 2011 at 07:55:34PM +0530, Vasanthakumar Thiagarajan wrote: > >> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@xxxxxxxxxxxxxxxx> > >> --- > >> drivers/net/wireless/ath/ath6kl/Kconfig | 6 ++++++ > >> drivers/net/wireless/ath/ath6kl/core.h | 1 + > >> drivers/net/wireless/ath/ath6kl/debug.c | 13 +++++++++++++ > >> drivers/net/wireless/ath/ath6kl/debug.h | 9 +++++++++ > >> drivers/net/wireless/ath/ath6kl/init.c | 6 ++++++ > >> 5 files changed, 35 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/net/wireless/ath/ath6kl/Kconfig b/drivers/net/wireless/ath/ath6kl/Kconfig > >> index 3d5f8be..ea9387b 100644 > >> --- a/drivers/net/wireless/ath/ath6kl/Kconfig > >> +++ b/drivers/net/wireless/ath/ath6kl/Kconfig > >> @@ -13,3 +13,9 @@ config ATH6KL_DEBUG > >> depends on ATH6KL > >> ---help--- > >> Enables debug support > >> +config ATH6KL_DEBUGFS > >> + bool "ath6kl debugfs" > >> + depends on ATH6KL_DEBUG && DEBUG_FS > > > > ATH6KL_DEBUGFS can be independent of ATH6KL_DEBUG. I'll send v2 > > fixing this. > > Actually do we really need ATH6KL_DEBUGFS? I would think that if both > ATH6KL_DEBUG and DEBUG_FS are enabled we should just enable debugfs code > in ath6kl. I don't see the need to have separate kconfig option control > that. You are right. We can directly use CONFIG_DEBUG_FS to enable ath6kl debugfs functionalities, also as I said, this does not need to depend on ATH6KL_DEBUG. One purpose that I can think of introducing a config option for debugfs is to reduce the size of the binary, may be it is very insignificant. Vasanth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
