Search Linux Wireless

Re: Bisected: ath9k: fix powersave frame filtering/buffering in AP mode broke STA association.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-05-06 6:58 PM, Ben Greear wrote:
On 05/06/2011 09:51 AM, Felix Fietkau wrote:
 On 2011-05-06 6:29 PM, Ben Greear wrote:
 On 05/05/2011 05:44 PM, Felix Fietkau wrote:

   This should fix the second issue:

   --- a/drivers/net/wireless/ath/ath9k/main.c
   +++ b/drivers/net/wireless/ath/ath9k/main.c
   @@ -1722,6 +1722,10 @@ static int ath9k_sta_add(struct ieee8021
     	struct ath_node *an = (struct ath_node *) sta->drv_priv;
     	struct ieee80211_key_conf ps_key = { };

   +	if (vif->opmode != NL80211_IFTYPE_AP&&
   +	    vif->opmode != NL80211_IFTYPE_AP_VLAN)
   +		return 0;
   +
     	ath_node_attach(sc, sta);
     	an->ps_key = ath_key_config(common, vif, sta,&ps_key);

 This doesn't compile..appears there is no vif->opmode member?

 Also, if you are trying to compare the hardware opmode, I'm not
 sure that would be correct since you can be in AP mode and still
 have stations.  Maybe I'm just confused though...
 I sent the wrong version of the patch, forgot to refresh it.
 Here's the correct one:

 --- a/drivers/net/wireless/ath/ath9k/main.c
 +++ b/drivers/net/wireless/ath/ath9k/main.c
 @@ -1722,6 +1722,10 @@ static int ath9k_sta_add(struct ieee8021
   	struct ath_node *an = (struct ath_node *) sta->drv_priv;
   	struct ieee80211_key_conf ps_key = { };

 +	if (vif->type != NL80211_IFTYPE_AP&&
 +	    vif->type != NL80211_IFTYPE_AP_VLAN)
 +		return 0;
 +
   	ath_node_attach(sc, sta);
   	an->ps_key = ath_key_config(common, vif, sta,&ps_key);



This patch appears to fix things.  I'll let you send it proper
for submittal since you have a better idea of what it's doing:
OK, thanks. I'll combine this with another ath9k patch to replace the rejected mac80211 PS filter patch and submit that for 2.6.39.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux