Search Linux Wireless

Re: Bisected: ath9k: fix powersave frame filtering/buffering in AP mode broke STA association.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/05/2011 02:54 PM, Felix Fietkau wrote:
On 2011-05-05 11:43 PM, Ben Greear wrote:
On 05/05/2011 02:15 PM, Ben Greear wrote:
On 05/05/2011 02:03 PM, Felix Fietkau wrote:
On 2011-05-05 10:44 PM, Ben Greear wrote:
I bisected the problem I was having with ath9k STA configured for WPA
not being able to authenticate. I'm using nohwcrypt=1, which may
be why no one else sees it.

I'll be happy to test patches, it seems very easy to reproduce on
my setup.
How about this?

--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1270,6 +1270,9 @@ ieee80211_tx_prepare(struct ieee80211_su
info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
else if (test_and_clear_sta_flags(tx->sta, WLAN_STA_CLEAR_PS_FILT))
info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
+ else if (sdata->vif.type != NL80211_IFTYPE_AP&&
+ sdata->vif.type != NL80211_IFTYPE_AP_VLAN)
+ info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;

hdrlen = ieee80211_hdrlen(hdr->frame_control);
if (skb->len> hdrlen + sizeof(rfc1042_header) + 2) {

Yes, that seems to fix the problem.

Thanks for the quick fix!

Well, that appeared to fix the problem on -rc1, but when I go
back to -rc6 and apply that patch, it still doesn't work.

Might be some other issue though...
Odd. Please try bisecting by applying the patch for each test and
reverting it before running git bisect again.

Unless I made a mistake, it's this patch that causes the next problem:

[greearb@build-32 linux.wt]$ git bisect bad
93ae2dd2230393566738a5f211ffbaa33b056d56 is the first bad commit
commit 93ae2dd2230393566738a5f211ffbaa33b056d56
Author: Felix Fietkau <nbd@xxxxxxxxxxx>
Date:   Sun Apr 17 23:28:10 2011 +0200

    ath9k: assign keycache slots to unencrypted stations

Makes me wonder if I'm the only one crazy enough to actually use
wireless testing :P

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux