On Wed, Apr 20, 2011 at 10:08:53AM +0200, Johannes Berg wrote: > On Wed, 2011-04-20 at 00:54 +0300, Arik Nemtsov wrote: > > > > That's your choice, but I wouldn't do it. You'll have to support TX > > > status when requested, otherwise AP operation won't work, so you need > > > the code anyway. > > > > Can you elaborate why? > > > > I'm assuming you mean the removal of > > IEEE80211_HW_REPORTS_TX_ACK_STATUS (in the second patch of this > > series). Note that it was only added recently, and AP/STA modes seemed > > to work fine without it. > > From a look in the code it seems this flag helps with connection > > monitoring in STA mode. The other use is determining the current PS > > mode when IEEE80211_HW_PS_NULLFUNC_STACK is enabled. These two are > > done by HW in wl12xx cards. > > Well, there's the flag saying "you can rely on it", but there's also the > fact that AP mode relies on status for (some) frames anyway. So if you > just want to remove the flag I guess that's OK, but if you want to > remove all status processing .. that'll cause issues with AP mode. Do the wl12xx guys still want this? -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
