On Tue, Apr 19, 2011 at 15:36, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2011-04-18 at 23:44 +0300, Arik Nemtsov wrote: > >> Well in a wl12xx chip we just configure some thresholds to the FW and >> it triggers the event for us. Using TX status doesn't really make >> sense since the FW has automatic rate control (so 50 tries are more >> like 50 * 8). > > Yeah same for the mac80211 approach, since we take packets, not retries. > >> > Also, are you sure? Do you really not get _any_ TX status? >> >> Currently we do get TX status, but there are plans to remove it later on. > > That's your choice, but I wouldn't do it. You'll have to support TX > status when requested, otherwise AP operation won't work, so you need > the code anyway. Can you elaborate why? I'm assuming you mean the removal of IEEE80211_HW_REPORTS_TX_ACK_STATUS (in the second patch of this series). Note that it was only added recently, and AP/STA modes seemed to work fine without it. >From a look in the code it seems this flag helps with connection monitoring in STA mode. The other use is determining the current PS mode when IEEE80211_HW_PS_NULLFUNC_STACK is enabled. These two are done by HW in wl12xx cards. Regards, Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html