On Tue, 2011-02-08 at 12:13 +0200, ext Kalle Valo wrote: > Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> writes: > > >> > I'm currently trying to find out if this is really needed or not. > >> > >> Sure, thanks. > > > > They are saying this is needed for OMAP's retention mode too, so AFAIK > > this is needed, not just for suspend. > > Why make this change in the driver? Doesn't it mean that all drivers > need to be changed so that they will work in your platform? I would > have expected that this is done automatically somewhere in the core > kernel and without any changes to the driver. > > To me platform specific changes in drivers are always problematic. Yeah I tend to agree. But then for some reason there is this interface in interrupts.h to do this, and AFAIU the one requesting the IRQ and controlling enabling and disabling of it is supposed to also tune this wakeing on/off. Apparently it should even do this when just enabling/disabling the interrupt - which are things performed in the driver. So in this case this would need to be a flag in the interrupt registration itself, so that the interrupt enable/disable calls could automatically control wake-up. I guess. -Juuso -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
