On Mon, Jan 31, 2011 at 05:37:16PM +0530, Johannes Berg wrote: > On Mon, 2011-01-31 at 17:23 +0530, Rajkumar Manoharan wrote: > > > > > list_for_each_entry(sdata, &local->interfaces, list) { > > > > if (!ieee80211_sdata_running(sdata)) > > > > continue; > > > > + if (((sdata->vif.type == NL80211_IFTYPE_AP) || > > > > + (sdata->vif.type == NL80211_IFTYPE_AP_VLAN)) && > > > > + !sdata->vif.p2p) { > > > > + count = 0; > > > > + break; > > > > > > I'd leave out the P2P check for now -- as soon as you have more than one > > > interface we don't go to PS, > > Not exactly. we are counting only station type, though we have multi vifs. > > Right -- that was confusing. > > > >and we don't have NoA things etc. yet. > > the p2p check means that infra AP only. > > Yeah but do we have any drivers that handle PS in P2P mode? I guess > iwlwifi might if you have the right firmware, but ath9k surely won't? > I'd rather not have to worry about it right now. Ok. I leave the p2p check and send the patch. Thanks for the review. -- Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html