On Mon, Jan 31, 2011 at 05:02:38PM +0530, Johannes Berg wrote:
> On Sun, 2011-01-30 at 19:06 +0530, Rajkumar Manoharan wrote:
> > PS should be disabled for AP type. So while recalculating
> > PS, AP vif type should be taken into account.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanoharan@xxxxxxxxxxx>
> > ---
> > net/mac80211/mlme.c | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> > index 3221069..1fd6023 100644
> > --- a/net/mac80211/mlme.c
> > +++ b/net/mac80211/mlme.c
> > @@ -601,6 +601,12 @@ void ieee80211_recalc_ps(struct ieee80211_local *local, s32 latency)
> > list_for_each_entry(sdata, &local->interfaces, list) {
> > if (!ieee80211_sdata_running(sdata))
> > continue;
> > + if (((sdata->vif.type == NL80211_IFTYPE_AP) ||
> > + (sdata->vif.type == NL80211_IFTYPE_AP_VLAN)) &&
> > + !sdata->vif.p2p) {
> > + count = 0;
> > + break;
>
> I'd leave out the P2P check for now -- as soon as you have more than one
> interface we don't go to PS,
Not exactly. we are counting only station type, though we have multi vifs.
>and we don't have NoA things etc. yet.
the p2p check means that infra AP only.
> Also, the VLAN check can go, since if there's a VLAN then there must
> also be an AP.
>
> Setting count to 0 is likely to be confusing to somebody trying to
> implement multi-interface PS though, a comment would be good.
Sure.
--
Rajkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
