On Mon, Jan 31, 2011 at 13:24, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > It'd be nicer if you could separate out mac80211 patches, but then Luca > needs to hold off merging until John picked up the mac80211 patch. Yea that would complicate matters a bit. Does the ordering of the patches bother you? > >> + * @IEEE80211_HW_AP_LINK_PS: When operating in AP mode the device >> + * autonomously manages the PS status of connected stations. When >> + * this flag is set mac80211 will not trigger PS mode for connected >> + * stations based on the PM bit of incoming frames. >> + * Use ieee80211_start_ps()/ieee8021_end_ps() to manually configure >> + * the PS mode of connected stations. > > You just renamed it. Yea thanks for that. > > Also, come to think of it, the ieee80211_sta_block_awake will not be > effective I think? Or will it? Haven't noticed any adverse effects. ap_sta_ps_end() still checks if the station is blocked before delivering queued packets. Also is should be pretty hard to find a driver that uses both mechanisms. If it wants to block a station from waking up, it can simply not call ieee80211_sta_ps_transition(). Should work though. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html