On Wed, 2011-01-26 at 23:51 +0200, Arik Nemtsov wrote: > On Wed, Jan 26, 2011 at 10:32, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Wed, 2011-01-26 at 08:00 +0200, Arik Nemtsov wrote: > > > >> >> > Why use a separate command for this, and not do it like the SSID? I also > >> >> > >> >> Its only relevant to AP-mode (at least for now) so bss_conf didn't > >> >> seem appropriate. > >> >> Also since its a dynamically allocated buffer it should be protected by RCU. > >> > > >> > But all that is unrelated to the nl80211 API, no? Also the SSID already > >> > uses bss_conf too, and it's AP mode too... > >> > >> Do you have a preferred alternative? > > > > What's wrong with putting it in the same place as the SSID? > > Just put it as a pointer inside ieee80211_bss_conf? (It will still > have to be RCU managed and all). > About nl80211 API - I tried making it as similar as possible to the > way the beacon works, but I guess I can pass it with bss_parameters as > well. Wait, no, I don't get it -- what does the nl80211 API have to do with how mac80211 manages it? I think for the nl80211 API the new command doesn't make a whole lot of sense. What happens in mac80211 I don't think matters much. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
