On Mon, Jan 24, 2011 at 13:35, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Sun, 2011-01-23 at 23:02 +0200, Arik Nemtsov wrote: >> Allow usermode to pass probe-response data. This data can be used as a >> template probe-response offloading. > > Why use a separate command for this, and not do it like the SSID? I also Its only relevant to AP-mode (at least for now) so bss_conf didn't seem appropriate. Also since its a dynamically allocated buffer it should be protected by RCU. > was under the impression you wanted both (which is somewhat redundant > since you can parse the SSID out of the probe response), so shouldn't > they both be required (or none, for compatibility)? The FW requires both the real SSID and a probe-response template. Passing the SSID separately looked cleaner. About compatibility - good point there. Currently the probe response template is set according to the beacon for compatibility. As for SSID - with the current wl12xx we'll set an empty SSID when a non-supporting hostapd is encountered. I'll fix that (in a v3). Other than that, we should be able to operate with either one configured. > > Also, should cfg80211 pretend it knows the SSID/probe response when > userspace didn't set it (from the beacon) so that mac80211 or the > low-level drivers don't need to worry? Well in the current patches sent to hostapd the probe response is always set with the beacon, so this shouldn't happen in AP mode. Its not supported in these patches for other modes.. Regards, Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
