On Tue, Jan 25, 2011 at 12:12, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2011-01-24 at 22:47 +0200, Arik Nemtsov wrote: >> On Mon, Jan 24, 2011 at 13:35, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Sun, 2011-01-23 at 23:02 +0200, Arik Nemtsov wrote: >> >> Allow usermode to pass probe-response data. This data can be used as a >> >> template probe-response offloading. >> > >> > Why use a separate command for this, and not do it like the SSID? I also >> >> Its only relevant to AP-mode (at least for now) so bss_conf didn't >> seem appropriate. >> Also since its a dynamically allocated buffer it should be protected by RCU. > > But all that is unrelated to the nl80211 API, no? Also the SSID already > uses bss_conf too, and it's AP mode too... Do you have a preferred alternative? > >> About compatibility - good point there. Currently the probe response >> template is set according to the beacon for compatibility. As for SSID >> - with the current wl12xx we'll set an empty SSID when a >> non-supporting hostapd is encountered. I'll fix that (in a v3). Other >> than that, we should be able to operate with either one configured. > > Does that mean if you set an empty SSID it won't reply but pass them up? > Then you could implement the behaviour I just asked for ... Well no. The FW never passes up beacons. You've helped uncover a bug where a non-supporting hostapd doesn't set the SSID and consequently we'll have an empty SSID configured to FW. In this case we should fallback to use the SSID extracted from the beacon. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
