On Tuesday, January 18, 2011 13:12:20 Johannes Berg wrote: > On Tue, 2011-01-18 at 13:01 +0100, Bernhard Schmidt wrote: > > > > + mutex_lock(&radar->mtx); > > > > > > Clearly, you haven't even tested this code. I'm not sure why I'm > > > even reviewing it. > > > > Granted, I did only some basic tests with only a few predefined > > scenarios, not at all is just wrong. Anyways, I should have > > mentioned in 0/13 that preventing channel changes while in CAC > > should be considered and chan should be assigned to local variable > > then. > > I was more referring to the fact that you're trying to lock a mutex > in a timer -- so you can't have executed this code path ever?! I'm running it right now, the code path *is* executed, what am I missing here? -- Best regards, Dipl.-Inf. (FH) Bernhard Schmidt (software development) saxnet GmbH, Willy-Brandt-Ring 1, 08606 Oelsnitz Tel. +49 (0) 3741 300 6. 100 - Fax +49 (0) 3741 300 6. 101 managing director: Steffen Dreise - county court Chemnitz - HRB 23017 http://www.saxnet.de -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
