On Tuesday, January 18, 2011 11:45:15 Johannes Berg wrote:
> On Mon, 2011-01-17 at 11:24 +0100, Bernhard Schmidt wrote:
> > ---
> >
> > net/mac80211/radar.c | 65
> > ++++++++++++++++++++++++++++++++++++++++++++++++++
> > net/mac80211/radar.h | 4 +++
> > 2 files changed, 69 insertions(+), 0 deletions(-)
> >
> > diff --git a/net/mac80211/radar.c b/net/mac80211/radar.c
> > index e90b8bf..afb2ae1 100644
> > --- a/net/mac80211/radar.c
> > +++ b/net/mac80211/radar.c
> > @@ -15,6 +15,66 @@
> >
> > #include "driver-ops.h"
> > #include "radar.h"
> >
> > +static void cac_timer(unsigned long data)
> > +{
> > + struct ieee80211_local *local = (void *) data;
> > + struct ieee80211_radar *radar = &local->radar;
> > + struct ieee80211_channel *chan;
> > +
> > + printk(KERN_INFO "CAC done\n");
> > +
> > + chan = local->oper_channel;
> > + mutex_lock(&radar->mtx);
>
> Clearly, you haven't even tested this code. I'm not sure why I'm even
> reviewing it.
Granted, I did only some basic tests with only a few predefined
scenarios, not at all is just wrong. Anyways, I should have mentioned in
0/13 that preventing channel changes while in CAC should be considered
and chan should be assigned to local variable then.
--
Best regards,
Dipl.-Inf. (FH) Bernhard Schmidt (software development)
saxnet GmbH, Willy-Brandt-Ring 1, 08606 Oelsnitz
Tel. +49 (0) 3741 300 6. 100 - Fax +49 (0) 3741 300 6. 101
managing director: Steffen Dreise - county court Chemnitz - HRB 23017
http://www.saxnet.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
