Search Linux Wireless

Re: [PATCH 4/5] mac80211: add primarily CAC support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-01-18 at 13:01 +0100, Bernhard Schmidt wrote:

> > > +	mutex_lock(&radar->mtx);
> > 
> > Clearly, you haven't even tested this code. I'm not sure why I'm even
> > reviewing it.
> 
> Granted, I did only some basic tests with only a few predefined 
> scenarios, not at all is just wrong. Anyways, I should have mentioned in 
> 0/13 that preventing channel changes while in CAC should be considered 
> and chan should be assigned to local variable then.

I was more referring to the fact that you're trying to lock a mutex in a
timer -- so you can't have executed this code path ever?!

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux