On Fri, Jan 14, 2011 at 8:06 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > I think that when we use ah->opmode, we should only use it for very generic > operating modes: > > AP: no TSF sync, beacon tx can be enabled. > ADHOC: TSF sync against IBSS cell, beacon tx can be enabled > STATION: TSF sync against one AP, only station beacon timers for PS. > > Only the above distinctions are relevant for ath9k_hw, everything else is > handled by the driver/stack. There is no reason for adding extra checks to > ath9k_hw for mesh and WDS, since they work best with ah->opmode set to AP, > and there is nothing extra on the *hardware* side that should be configured > there via a different opmode. That's why I think leaking the mac80211 > interface types to ath9k_hw is a bad idea. Isn't that also a good argument against using nl80211_iftype in this context? The values currently defined are: * @NL80211_IFTYPE_ADHOC: independent BSS member * @NL80211_IFTYPE_STATION: managed BSS member * @NL80211_IFTYPE_AP: access point * @NL80211_IFTYPE_AP_VLAN: VLAN interface for access points * @NL80211_IFTYPE_WDS: wireless distribution interface * @NL80211_IFTYPE_MONITOR: monitor interface receiving all frames * @NL80211_IFTYPE_MESH_POINT: mesh point * @NL80211_IFTYPE_P2P_CLIENT: P2P client * @NL80211_IFTYPE_P2P_GO: P2P group owner But what we really want to do is keep track of TSF sync and beaconing. For beacon we have already given up on opmode and now use nbcnvifs. Perhaps we could find some similar way to handle TSF sync? /Björn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
