On Wed, Jan 12, 2011 at 10:36:28PM +0530, Björn Smedman wrote: > On Wed, Jan 12, 2011 at 3:30 PM, Rajkumar Manoharan > <rmanoharan@xxxxxxxxxxx> wrote: > > The commit ""ath9k: Add change_interface callback" was failed > > to update of hw opmode, ani and interrupt mask. This leads > > to break p2p functionality on ath9k. And the existing add and > > remove interface functions are not handling hw opmode and > > ANI properly. > > > > This patch combines the common code in interface callbacks > > and also takes care of multi-vif cases. > > How does your patch handle the race condition between the interface > change done in process context and the beacon tasklet triggered by > SWBA? If you look at the patch, while removing/changing AP/IBSS interface, SWBA interrupt was disabled and beacon tasklet is killed before releasing beacon slot. The SWBA will enabled again in the presence of beaconing interface. > > Also, perhaps more applicable to the commit log than the patch, how > can opmode be properly handled in multi-vif cases? I mean let's say I > have two AP vifs and then change one into STA, is the opmode then STA? If you have any AP vifs, then opmode will always be AP type. STA mode will be set only if there is no beaconing interface. > Compare that to the case where I have two STA vifs and change one into > AP; so again I have one AP and one STA vif but this time opmode is AP, > right? I can see how I can be wrong about these examples but I can't > really see how the opmode concept can be properly handled in multi-vif > cases. If you are changing STA->AP, then opmode also changed to AP type though you have other STA interfaces. -- Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
