Search Linux Wireless

Re: [RFC PATCH 5/6] zd1211rw: implement beacon fetching and handling ieee80211_get_buffered_bc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting RafaÅ MiÅecki <zajec5@xxxxxxxxx>:

2010/12/26 Jussi Kivilinna <jussi.kivilinna@xxxxxxxx>:
+ Â Â Â if (mac->vif || mac->vif->type == NL80211_IFTYPE_UNSPECIFIED)
+ Â Â Â Â Â Â Â return;

That's smelly. I think you meant negation in first part of condition.

Heh.. well that fixed broadcast/multicast buffering. Thanks.



- Â Â Â if (int_status & INT_CFG_NEXT_BCN)
+ Â Â Â if (int_status & INT_CFG_NEXT_BCN) {
       Âdev_dbg_f_limit(zd_mac_dev(mac), "INT_CFG_NEXT_BCN\n");
- Â Â Â else
+ Â Â Â Â Â Â Â zd_beacon_done(mac);
+ Â Â Â } else
       Âdev_dbg_f(zd_mac_dev(mac), "Unsupported interrupt\n");

Minor thing, check http://www.kernel.org/doc/Documentation/CodingStyle

This does not apply if one branch of a conditional statement is a single
statement. Use braces in both branches.

Use brackets for "else" as well please.


Ok.

-Jussi

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux