Quoting RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
2010/12/26 Jussi Kivilinna <jussi.kivilinna@xxxxxxxx>:
-static int set_beacon_interval(struct zd_chip *chip, u32 interval)
+static int set_beacon_interval(struct zd_chip *chip, u32 interval,
+ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âu16 dtim_period)
That gets messy. We have interval in interval, flags in interval and
period in dtim_period :|
Do you have idea what is maximum value for dtim_period? It sounds like
it should be 0xff.
Could we maybe try sth like:
u16 interval, u8 dtim_period, u8 flags? Then we would have
flags << 24 | dtim_period << 16 | interval
Or maybe to avoid problems with shifting flags (re-defining defines?),
we could use a little more messy
flags | dtim_period << 16 | interval
Or do you have better idea? Proposed one doesn't seem really clear for me.
Vendor driver uses u16 interval, u8 dtim_p, u8 mode and selects right
flags based on interval. I'll something like change to that, I think
caller shouldn't be setting hw flags here anyway.
-Jussi
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
