2010/12/26 Jussi Kivilinna <jussi.kivilinna@xxxxxxxx>:
> + Â Â Â if (mac->vif || mac->vif->type == NL80211_IFTYPE_UNSPECIFIED)
> + Â Â Â Â Â Â Â return;
That's smelly. I think you meant negation in first part of condition.
> - Â Â Â if (int_status & INT_CFG_NEXT_BCN)
> + Â Â Â if (int_status & INT_CFG_NEXT_BCN) {
> Â Â Â Â Â Â Â Âdev_dbg_f_limit(zd_mac_dev(mac), "INT_CFG_NEXT_BCN\n");
> - Â Â Â else
> + Â Â Â Â Â Â Â zd_beacon_done(mac);
> + Â Â Â } else
> Â Â Â Â Â Â Â Âdev_dbg_f(zd_mac_dev(mac), "Unsupported interrupt\n");
Minor thing, check http://www.kernel.org/doc/Documentation/CodingStyle
> This does not apply if one branch of a conditional statement is a single
> statement. Use braces in both branches.
Use brackets for "else" as well please.
--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
