On Fri, 2010-10-01 at 14:05 +0200, Stanislaw Gruszka wrote: > Merge common code using goto instruction. Except less LOC, one of > the benefit is decrease number of places where function > ieee80211_scan_completed() is called. > + int rc = 1; This shouldn't be necessary, and will only serve to hide warnings if somebody rearranges this code in the future. > + bool aborted = true; I'd prefer also not initialising this here and putting the = true into all the few places that need it so that we get warnings for new places that jump to the completed w/o properly setting aborted. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html