Search Linux Wireless

Re: [PATCH 2/6] mac80211: merge ieee80211_scan_work() common code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-10-01 at 14:05 +0200, Stanislaw Gruszka wrote:
> Merge common code using goto instruction. Except less LOC, one of
> the benefit is decrease number of places where function
> ieee80211_scan_completed() is called.

> +	int rc = 1;

This shouldn't be necessary, and will only serve to hide warnings if
somebody rearranges this code in the future.

> +	bool aborted = true;

I'd prefer also not initialising this here and putting the = true into
all the few places that need it so that we get warnings for new places
that jump to the completed w/o properly setting aborted.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux