Search Linux Wireless

Re: [PATCH 2/6] mac80211: merge ieee80211_scan_work() common code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-10-01 at 14:05 +0200, Stanislaw Gruszka wrote:

> +out_complete:
> +	mutex_unlock(&local->mtx);
> +	if (rc)
> +		__ieee80211_scan_completed(&local->hw, true);

That must be aborted, not "true".

Also, I just noticed that together with the other patch this gets quite
confusing with the "if (rc)" logic. I think

out_complete:
	mutex_unlock
	completed()
	return;
out:
	mutex_unlock()
}

would ultimately be easier to understand.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux