On Wed, Jun 16, 2010 at 07:08:24PM +0530, John W. Linville wrote: > On Wed, Jun 16, 2010 at 11:21:27AM +0530, Vivek Natarajan wrote: > > On Wed, Jun 16, 2010 at 1:21 AM, John W. Linville > > <linville@xxxxxxxxxxxxx> wrote: > > > On Tue, Jun 15, 2010 at 10:50:17AM +0530, Vivek Natarajan wrote: > > >> Some vendors require the LED to be ON always irrespective of any > > >> radio activity. Introducing a module parameter to enable this, > > >> so that one can choose between always on or led blink during > > >> activity. > > >> > > >> Signed-off-by: Vivek Natarajan <vnatarajan@xxxxxxxxxxx> > > > > > > Any particular reason the always-on behaviour is the default? > > > > There is no specific reason for setting it as default. It is only that > > some customers preferred the led to be always on instead of blinking. > > Well it is just that as I read the patch, you are changing the > behaviour for everyone rather than simply giving a new option for > those that don't like it that way it already is. > > Look, I don't particular care about the behaviour. Blinking w/ > activity makes sense to me. But I also get to read the seemingly > endless, whining complaints about how the blinking is distracting for > laptop users. I just would rather not add another endless stream of > complaints that say "my wifi LED used to blink w/ activity, now it > doesn't -- fix it!" I agree with John. Let's not change the existing default pattern (blinking during activity) and use this option to disable blinking if someone wants it. > > Perhaps we could standardize this somehow? Anyone care to make > a proposal? > > John > -- > John W. Linville Someday the world will need a hero, and you > linville@xxxxxxxxxxxxx might be all we have. Be ready. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
