On Thu, 2010-04-15 at 17:38 -0400, Luis R. Rodriguez wrote: > From: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> > > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> > - struct ath_desc *bf_desc; /* virtual addr of desc */ > + void *bf_desc; /* virtual addr of desc */ Why? The obvious downside is that bf_desc becomes compatible with pointers of any type. The only upside I can think of is that bf_desc won't be dereferenced by accident. The same could be done by using a scalar type or __attribute__((noderef)). I believe the downside outweighs the upside in absence of any explanation. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
