On Mon, Mar 08, 2010 at 02:20:30AM -0800, Jason Dreisbach wrote: > From: Jason <jtdreisb@xxxxxxxxx> > /* Check mc_config command */ > if ((status & AC_SFLD_OK) != AC_SFLD_OK) > printk(KERN_INFO > - "%s: wv_config_complete(): set_multicast_address failed; status = 0x%x\n", > + "%s: wv_config_complete(): \ > + set_multicast_address failed; status = 0x%x\n", > dev->name, status); > This patch introduces several bugs like the one above. I know it's depressing to send a patch and have criticized, but besides this bug which affects users there are some other whitespace changes in this patch which are not correct. If you want to resend this once you fix the errors, feel free, it does fix quite a few white space issues. But really it's always better to focus on fixing actual bugs. I know that Greg says fixing white space is a great way to learn the patch submission process, but anyone can do that. The most important thing is to learn how to fix bugs. We can deal with malformed patches so long as they fix something. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
