On Sun, Mar 7, 2010 at 8:17 PM, Bruno Randolf <br1@xxxxxxxxxxx> wrote: > On Monday 08 March 2010 12:56:52 Luis R. Rodriguez wrote: >> On Sun, Mar 7, 2010 at 6:59 PM, Bruno Randolf <br1@xxxxxxxxxxx> wrote: >> > I/Q calibration was completely broken, resulting in a high number of CRC >> > errors on received packets. before i could see around 10% to 20% CRC >> > errors, with this patch they are between 0% and 3%. >> > >> > 1.) the removal of the mask in commit "ath5k: Fix I/Q calibration >> > (f1cf2dbd0f798b71b1590e7aca6647f2caef1649)" resulted in no mask beeing >> > used when writing the I/Q values into the register. additional errors in >> > the calculation of the values (see 2.) resulted too high numbers, >> > exceeding the masks, so wrong values like 0xfffffffe were written. to be >> > safe we should always use the bitmask when writing parts of a register. >> > >> > 2.) using a (s32) cast for q_coff is a wrong conversion to signed, since >> > we convert to a signed value later by substracting 128. this resulted in >> > too low numbers for Q many times, which were limited to -16 by the >> > boundary check later on. >> > >> > 3.) checked everything against the HAL sources and took over comments and >> > minor optimizations from there. >> > >> > 4.) we can't use ENABLE_BITS when we want to write a number (the number >> > can contain zeros). also always write the correction values first and >> > set ENABLE bit last, like the HAL does. >> > >> > Signed-off-by: Bruno Randolf <br1@xxxxxxxxxxx> >> > --- >> > v2: use clamp() as Bob suggested >> >> Thanks Bruno, are these stable fixes? > > hi luis! > > i think so. the behaviour before was completely broken, now it's better. > > but i'm not sure about that whole Cc: stable@xxxxxxxxxx thing... (sorry i've > been away for a while)... i read Documentation/stable_kernel_rules.txt but > still not sure if that applies for this patch. Just add: Cc: stable@xxxxxxxxxx below your Singed-off-by on the commit log entry. That list will get spammed once the patch is merged on Linus' tree. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
