On Sun, 2010-01-24 at 12:45 +0100, Michael Buesch wrote: > On Sunday 24 January 2010 12:32:50 Johannes Berg wrote: > > > >>> We can just remove the lock and add a comment explaining why it is not locked... > > > > Mind you, it won't work on SDIO hardware since the callback cannot > > sleep, contrary to what Kalle documented :( > > I don't understand. Why wouldn't SDIO be allowed to sleep? Because this is called within the RX path code which does rcu_read_lock() around it. Really, somebody just needs to go and add key TODO in mac80211 to pick up phase1 key changes and update them in the driver, that gets rid of all the locking and atomic problems. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part