On Sunday 24 January 2010 12:47:52 Johannes Berg wrote: > On Sun, 2010-01-24 at 12:45 +0100, Michael Buesch wrote: > > On Sunday 24 January 2010 12:32:50 Johannes Berg wrote: > > > > >>> We can just remove the lock and add a comment explaining why it is not locked... > > > > > > Mind you, it won't work on SDIO hardware since the callback cannot > > > sleep, contrary to what Kalle documented :( > > > > I don't understand. Why wouldn't SDIO be allowed to sleep? > > Because this is called within the RX path code which does > rcu_read_lock() around it. Ok, I see. I can live with that, because tkip hwcrypto defaults to off. > Really, somebody just needs to go and add key TODO in mac80211 to pick > up phase1 key changes and update them in the driver, that gets rid of > all the locking and atomic problems. Too bad I don't understand all that tkip key handling stuff. :) -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
