On Sat, 2010-01-23 at 23:58 -0600, Larry Finger wrote: > On 01/23/2010 01:38 PM, Michael Buesch wrote: > > On Saturday 23 January 2010 20:31:43 Larry Finger wrote: > >> On 01/23/2010 01:00 PM, Michael Buesch wrote: > >>> On Saturday 23 January 2010 19:53:48 Johannes Berg wrote: > >>>> Actually you can't, because you can't acquire the mutex here since we're > >>>> in an atomic section. So relying on it being already locked is probably > >>>> safer. However, you can't actually sleep anyway... > >>> > >>> I'm OK with removing the lock from the callback, if it is guaranteed that > >>> the callback is only called on behalf of a RX call. > >>> > >>> We can just remove the lock and add a comment explaining why it is not locked... Mind you, it won't work on SDIO hardware since the callback cannot sleep, contrary to what Kalle documented :( Why is it not giving everybody warnings in might_sleep()? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
