On 9 Nov 2009, at 13:27, Johannes Berg wrote:
Hi,
On Mon, 2009-11-09 at 12:39 +0000, Rui Paulo wrote:
Process the RX of RANN information elements.
That commit log is not really right.
You're right. Is "Parse the RANN information element" a better one?
You're not really parsing them either ... Maybe "add code to find RANN
IE" or something? Doesn't matter that much. For all I care 11 and 12
could be collapsed into one patch.
Ok, I'll merge 11 and 12.
I'd definitely prefer if here you added a 17-byte long struct that
explains the layout of the IE, and then used that in patch 12. Also
it's
probably useful to check the length directly in
ieee802_11_parse_elems.
I prefer structures describing the IE layout too, but I was following
the mesh code on this. If structure layouts are preferable, then
there
are 4 mesh IEs that should probably be changed.
Yeah, but I think at least one of them had a problem with struct
description because it was kinda variable. Not sure if that's still
the
case though.
There are two variable IEs according to the latest draft. Right now we
only support the fixed case (i.e., IEs have only one target and target
count == 1) so we can make it a struct and deal with it later,
assuming there's nothing wrong with using a struct to hold variable
data (I see that we already use structs to hold variable IEs).
Regarding to the length check, I was also following the way the mesh
code does it. Again, if we want to change RANN, we should probably
also change PREQ, PREP and PERR.
True too.
But you were just adding a new one, so I figured I could ask you to
make
the new one nicer, but couldn't really ask you to fix the old
ones :) If
you want to, I'd welcome it.
Heh, ok. :-)
--
Rui Paulo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
