Hi Johannes,
On 9 Nov 2009, at 12:59, Johannes Berg wrote:
On Mon, 2009-11-09 at 12:39 +0000, Rui Paulo wrote:
Process the RX of RANN information elements.
That commit log is not really right.
You're right. Is "Parse the RANN information element" a better one?
+ WLAN_EID_RANN = 49, /* compatible with FreeBSD */
/* 802.11h */
WLAN_EID_PWR_CONSTRAINT = 32,
WLAN_EID_PWR_CAPABILITY = 33,
I'd definitely prefer if here you added a 17-byte long struct that
explains the layout of the IE, and then used that in patch 12. Also
it's
probably useful to check the length directly in
ieee802_11_parse_elems.
I prefer structures describing the IE layout too, but I was following
the mesh code on this. If structure layouts are preferable, then there
are 4 mesh IEs that should probably be changed.
Regarding to the length check, I was also following the way the mesh
code does it. Again, if we want to change RANN, we should probably
also change PREQ, PREP and PERR.
Thanks,
--
Rui Paulo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
