On Mon, Sep 14, 2009 at 03:18:24PM -0500, Larry Finger wrote: > Thomas Ilnseher wrote: > > On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote: > >> Always send patches to John Linville, and CC linux-wireless. > > Ok, the last try ... > > > > As I've seen Gàbor's patch, I noticed that my previous patch was > > bullshit. This patch should work: > > > > (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore) > > > > Signed-off-by: Thomas Ilnseher <illth@xxxxxx> > > > > A few points about patch formatting. > > The subject of the submittal message should be of the form "[PATCH] > component: Description". For this one, something like "[PATCH] b43: > Add LP PHY analog switch support" would be appropriate. If multiple > versions are needed, indicate that a previous one is superceded by > [PATCH V2] ..., etc. > > There should be a line containing --- after the last signed-off-by line. > > Anything between the beginning of the e-mail and the --- line becomes > part of the permanent record if the patch is accepted. Usually quoted > material and words like bullshit are avoided. Not always, but usually. > > Between the --- line and the start of the patch, you can place > instructions to Linville regarding the circumstances of the patch and > its priority. Such directions are useful to distinguish an improvement > that should wait for the next merge period from a bug fix that should > be sent upstream ASAP. In this case, the patch fixes a system crash on > some platforms and should be applied now. Above is a good summary. I usually refer people here (which has mostly the same information): http://linux.yyz.us/patch-format.html Hth! John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
