On Thursday 03 September 2009 01:02:59 Joerg Albert wrote:
>
> This patch adds the initialisation of some PHY registers
> from the modal_header[] values in the EEPROM
> (see otus/hal/hpmain.c, line 333 ff.)
>
> Signed-off-by: Joerg Albert <jal2@xxxxxx>
Acked-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
> ---
>
> Compared to v1 I've included Christian's suggestions and removed
> three unnecessary defval assignments for "ant * control".
>
> This patch seems to depend on Christian's
> "[RFT] ar9170: use eeprom's frequency calibration values"
> (2009-08-21), I get a poor throughput here without it (1-stage fw,
> 802.11g AP).
Good work!
with both patches applied, my WNDA is finally able to pick up some
speed. But, it's still a mbit slower than the two-stage fw.
> drivers/net/wireless/ath/ar9170/phy.c | 136 ++++++++++++++++++++++++++++++++-
> 1 files changed, 135 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ar9170/phy.c b/drivers/net/wireless/ath/ar9170/phy.c
> index df86f70..8fb1fa8 100644
> --- a/drivers/net/wireless/ath/ar9170/phy.c
> +++ b/drivers/net/wireless/ath/ar9170/phy.c
> @@ -396,6 +396,138 @@ static struct ar9170_phy_init ar5416_phy_init[] = {
> { 0x1c9384, 0xf3307ff0, 0xf3307ff0, 0xf3307ff0, 0xf3307ff0, }
> };
>
> +/*
> + * look up a certain register in ar5416_phy_init[] and return the init. value
> + * for the band and bandwidth given. Return 0 if register address not found.
> + */
> +static u32 ar9170_get_default_phy_reg_val(u32 reg, bool is_2ghz, bool is_40mhz)
[...]
> + /* xpd gain mask (index 14) */
> + defval = ar9170_get_default_phy_reg_val(0x1c6258, is_2ghz, is_40mhz);
> + newval = (defval & ~0xf0000) | (xpd2pd[m->xpdGain & 0xf] << 16);
> + ar9170_regwrite(0x1c6258, newval);
> +
> +
John, can you please nuke those two empty lines?
> + ar9170_regwrite_finish();
> +
> + return ar9170_regwrite_result();
> +}
> +
> int ar9170_init_phy(struct ar9170 *ar, enum ieee80211_band band)
> {
> int i, err;
> @@ -426,7 +558,9 @@ int ar9170_init_phy(struct ar9170 *ar, enum ieee80211_band band)
> if (err)
> return err;
>
> - /* XXX: use EEPROM data here! */
uh, I think we're still missing the heavy clip/conformance?
(otus/hal/hpmain.c, line 3723 ff.).
It should be modified to say something like:
/* TODO: (heavy clip) regulatory domain power level fine-tuning. */
> + err = ar9170_init_phy_from_eeprom(ar, is_2ghz, is_40mhz);
> + if (err)
> + return err;
>
> err = ar9170_init_power_cal(ar);
> if (err)
Regards,
Chr
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
