On Mon, Aug 17, 2009 at 02:04:44PM +0800, Zhu Yi wrote: > nl80211 driver connect API support. > V2: Use auth/assoc as the default operations if they are supported. Thanks! It looks like there is still some misunderstanding regarding the SME design in wpa_supplicant. It was designed to be used when the driver does provide the separate authentication and association commands. There is not much point in trying to convert the SME implementation to work with the case where connect command is used. It is just duplicating functionality that is already present in the old associate (pre-auth/assoc SME case) operation. I took about half of the patch, i.e., the changes to add driver capability query, connect events, and actual connect/disconnect functions. Instead of the changes in sme.c and driver interface, I glued the new functions together within driver_nl80211.c since rest of wpa_supplicant do not really need to (nor should) know about yet another driver operation for connecting in a single step. The driver capabilities are used to select which functions to use within driver_nl80211.c. Since the WPA_DRIVER_FLAGS_SME is now set based on driver capabilities, core wpa_supplicant code is able to switch between the SME (separate auth/assoc calls) and single associate ("connect" in nl80211 terminology) call. I did not go through the details of sme_connect() function, but I would expect that it was providing the same conversion from configuration to driver parameters that was already done in wpa_supplicant.c. If there was something else there, it should be added to the version in wpa_supplicant.c instead of introducing a new, duplicated function. It looks like the end result works fine at least with mac80211_hwsim (with hardcoded driver capability detection that does not find the separate authenticate command). This version is now in my git repository and it would be good if you could verify that it works with your driver, too. -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html