On Sat, 2009-08-22 at 15:03 -0700, Rafael Laufer wrote: > >> + * @IEEE80211_TX_CTL_RATE_RADIOTAP: completely internal to mac80211, > >> + * used to indicate that the rate was defined in the received radiotap > >> + * header and therefore the rate control algorithm should not change it. > >> > > > > This should be an internal flag, the driver doesn't care. > > > > right, and where are those set? It's just a naming thing really. Look at the other flags. > >> + /* Get the rate parameter from the radiotap header, > >> + * allowing rate selection on a per-packet basis > >> + */ > >> > > > > coding style > > > > I am a newbie, I am gonna look into the coding style, but I assume you > are talking about the missing blank line in the beginning What Kalle said. Sorry to be a bit terse at times. > This is a good point and now I see that Gábor pointed this out as well. > There are other fields in the radiotap header that define the RTS and > DATA retries. However, if those fields are not set, there must be a > default value in this case. Are there any? Well there's the short and long retry counts, that could be used I guess. It would make some sense to do that. And the RTS/CTS-to-self determination should probably be made by the network in absence of explicit configuration, but the tx_h_rate_ctrl function should do that already I think, even if you skip the rate control algorithm. Same with short preamble or not. If you want to support only the rate, I suspect that leaving the flags and setting just the rate index/count will be sufficient. Unfortunately, you'll have to take a closer look at the code to determine it. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
