Search Linux Wireless

Re: [PATCH] Implementation of the IEEE80211_RADIOTAP_RATE option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2009-08-21 at 11:03 -0700, Rafael Laufer wrote:

> + * @IEEE80211_TX_CTL_RATE_RADIOTAP: completely internal to mac80211,
> + *	used to indicate that the rate was defined in the received radiotap
> + *	header and therefore the rate control algorithm should not change it.

This should be an internal flag, the driver doesn't care.

> +	/* In monitor mode, if the IEEE80211_RADIOTAP_RATE option is set in 
> +	 * the received radiotap header, do not call the rate control algorithm.
> +	 */

coding style

> +		/* Get the rate parameter from the radiotap header, 
> +		 * allowing rate selection on a per-packet basis 
> +		 */

coding style

> +		case IEEE80211_RADIOTAP_RATE:
> +			bitrate = (*iterator.this_arg) * 5;
> +			for (i = 0; i < sband->n_bitrates; i++) {
> +				if (sband->bitrates[i].bitrate == bitrate)
> +					break;
> +			}
> +			if (i != sband->n_bitrates) {
> +				info->control.rates[0].idx = i;
> +				info->flags |= IEEE80211_TX_CTL_RATE_RADIOTAP;
> +			}

You never set the counter, or any other fields.

>  		/*
>  		 * Please update the file
>  		 * Documentation/networking/mac80211-injection.txt

And you even quote the instructions.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux