Johannes Berg wrote:
On Fri, 2009-08-21 at 13:21 -0700, Rafael Laufer wrote:
It is strange that a function called "get_rate" would also change other
fields which are at first sight do not look related to rate. Why not
call other functions for that? What is the reasoning behind this?
Different rates have different retry counts or RTS/CTS usage?
I can't tell if you're kidding or not. This also doesn't get a single
rate, but the entire rate control setup.
As far as I could tell from a quick look in the code,
rate_control_get_rate only sets the fields of info->control.rates,
except for this driver-specific function.
Right. And now look again what's in control.rates[].
ok, I get it now. The flags and count also need to be set. Anything else?
If this function really does other stuff, then a simple solution is to
check if the IEEE80211_TX_CTL_RATE_RADIOTAP flag is set and, in that
case, store the value of info->control.rates[0].idx before calling
rate_control_get_rate, and restoring it afterwards. Make sense?
Ick, no.
though so, it's so ugly
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
