On Tue, 28/07/2009 at 17:25 +0200, Johannes Berg wrote: > On Tue, 2009-07-28 at 18:17 +0400, Igor Perminov wrote: > > > And in case we introduce the FIF_PSPOLL flag, what the exact semantics > > will it have? When the FIF_CONTROL flag is passed to a driver, but the > > FIF_PSPOLL one isn't, should the driver filter out PS Poll frames (a) or > > not (b)? > > Like all filter flags, FIF_PSPOLL would mean "give us PSPOLL frames > please", so (b). And one more question. How will a driver behave in case a device has no a separate hardware filter for PS Poll frames? I.e. what value should the driver return from configure_filter in total_flags? In case there is one common filter for all control frames, it's an easy thing. If FIF_CONTROL or FIF_PSPOLL are passed to driver's configure_filter in total_flags, both of them should be set there and the filter should be configured to pass through all control frames. And suppose a device has two filters: one for ACK frames and one for all other control frames. Suppose FIF_CONTROL is passed in total_flags only. In that case the driver sets FIF_PSPOLL there and configures both filters to pass through frames. Right? And what if FIF_PSPOLL is passed in total_flags only? In that case the ACK filter should be configured to filter out ACK frames (otherwise it would have performance overhead at least). And the second filter is configured to pass through frames only (i.e. all control frames except for ACK). So, the driver will receive not only PS Poll control frames, but some others. The question here is: should the driver set FIF_CONTROL in total_flags or not in that case? Igor -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
