On Wed, May 13, 2009 at 3:27 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2009-05-13 at 14:00 -0400, Bob Copeland wrote: >> On Wed, May 13, 2009 at 1:20 PM, Luis R. Rodriguez >> <lrodriguez@xxxxxxxxxxx> wrote: >> > On Wed, May 13, 2009 at 2:53 AM, Johannes Berg >> > <johannes@xxxxxxxxxxxxxxxx> wrote: >> >> On Wed, 2009-05-13 at 05:20 -0400, Luis R. Rodriguez wrote: >> >>> We inform the drivers so they can take appropriate actions during >> >>> suspend for WoW support. >> >> >> >>> -static void ar9170_op_stop(struct ieee80211_hw *hw) >> >>> +static void ar9170_op_stop(struct ieee80211_hw *hw, bool suspend) >> >> Just curious, why can't the bus suspend method just turn the radio back on? >> You have to set up the wow parameters later anyway. >> >> I think it'd be cleaner if the stack knew about WoW somehow rather than >> doing stuff behind its back in the driver. Then suspend/resume could do >> the right thing (e.g. ops->wow_enable() instead of stop) if the driver was >> WoW-capable. > > That's a good point. Somehow I thought this was intimately tied to > suspend. And I think for cfg80211 that makes sense, since cfg80211 > doesn't do much for suspend. But for mac80211 you're right in that it > would make sense to > * keep the radio on This is implicit by not calling stop, right? > * not call stop This makes sense for ath9k so far -- I was just exiting out. > * maybe not remove all the sta info structs Which ones? In my tests I'm just not removing any. > * and whatever else may be necessary -- that might even depend on the > wow mode So lets start with a basic goal -- magic packet. If you think about it though if you disassociate you won't get this magic packet so I guess that's also why we have link-change trigger (or called disassoc trigger on some other hardware?). Anyway out of these link change and magic packet seem like a reasonable goal to get working first. For that besides the above I'm not sure what else is required. I'm building this stuff now on a box with a card that is supposed to have WoW working so I'll know for sure if we are missing something soon. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
