On Wed, May 13, 2009 at 2:53 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2009-05-13 at 05:20 -0400, Luis R. Rodriguez wrote: >> We inform the drivers so they can take appropriate actions during >> suspend for WoW support. > >> -static void ar9170_op_stop(struct ieee80211_hw *hw) >> +static void ar9170_op_stop(struct ieee80211_hw *hw, bool suspend) > > Why just a 'suspend' bool? Why not pass the WoW information in here, > instead of adding a new config and stuff for it? WoW information is only > relevant during suspend. > > The way you have it, a driver needs to > * keep track of the wow config > * check whether a stop is due to suspend > * apply wow config during stop > > If you passed the wow config in some struct to _stop() [and NULL if not > for wow] then the driver would only need to > > * check if for wow and apply config during stop Reason for not passing it is its accessible through the wiphy. All we really need from mac80211 is if it changed (some devices may need this, and will be more useful for the user pattern handling) and if we are stopping due to suspend. What advantage do we have if we stuff a wow struct instead of having the driver read the wiphy wow info? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
