Search Linux Wireless

Re: [RFC v2 2/5] mac80211: inform devices when we are suspending on the stop callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-05-13 at 05:20 -0400, Luis R. Rodriguez wrote:
> We inform the drivers so they can take appropriate actions during
> suspend for WoW support.

> -static void ar9170_op_stop(struct ieee80211_hw *hw)
> +static void ar9170_op_stop(struct ieee80211_hw *hw, bool suspend)

Why just a 'suspend' bool? Why not pass the WoW information in here,
instead of adding a new config and stuff for it? WoW information is only
relevant during suspend.

The way you have it, a driver needs to
 * keep track of the wow config
 * check whether a stop is due to suspend
 * apply wow config during stop

If you passed the wow config in some struct to _stop() [and NULL if not
for wow] then the driver would only need to

 * check if for wow and apply config during stop

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux